Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate file:subfile:name and add :path=<file:path> property. #2043

Merged
merged 5 commits into from
Jan 11, 2021

Conversation

invisig0th
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #2043 (c972a41) into master (1a1f5fe) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2043      +/-   ##
==========================================
- Coverage   96.79%   96.62%   -0.17%     
==========================================
  Files         149      149              
  Lines       29247    29247              
==========================================
- Hits        28310    28261      -49     
- Misses        937      986      +49     
Flag Coverage Δ
linux 96.62% <ø> (-0.17%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/models/files.py 99.10% <ø> (ø)
synapse/tests/utils.py 93.66% <0.00%> (-2.16%) ⬇️
synapse/lib/spawn.py 89.20% <0.00%> (-0.96%) ⬇️
synapse/cortex.py 95.76% <0.00%> (-0.76%) ⬇️
synapse/lib/hiveauth.py 96.05% <0.00%> (-0.76%) ⬇️
synapse/lib/view.py 94.22% <0.00%> (-0.70%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
synapse/common.py 97.43% <0.00%> (-0.29%) ⬇️
synapse/lib/lmdbslab.py 99.41% <0.00%> (-0.20%) ⬇️
synapse/lib/layer.py 98.12% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a1f5fe...c972a41. Read the comment docs.

@invisig0th invisig0th changed the title Change file:subfile:name to a file:path Deprecate file:subfile:name and add :path=<file:path> property. Jan 4, 2021
@invisig0th invisig0th merged commit cce6f10 into master Jan 11, 2021
@invisig0th invisig0th deleted the visi-subfile-name branch January 11, 2021 17:14
@vEpiphyte vEpiphyte added this to the v2.21.0 milestone Jan 19, 2021
@vEpiphyte vEpiphyte modified the milestones: v2.21.0, v2.22.0 Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants