Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layer.getPropCount for univ props #2073

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Fix layer.getPropCount for univ props #2073

merged 3 commits into from
Feb 4, 2021

Conversation

Cisphyx
Copy link
Contributor

@Cisphyx Cisphyx commented Feb 4, 2021

No description provided.

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #2073 (b4dc6f5) into master (a4b2959) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2073      +/-   ##
==========================================
- Coverage   96.89%   96.74%   -0.15%     
==========================================
  Files         149      149              
  Lines       29560    29568       +8     
==========================================
- Hits        28642    28606      -36     
- Misses        918      962      +44     
Flag Coverage Δ
linux 96.74% <100.00%> (-0.15%) ⬇️
linux_replay ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
synapse/lib/layer.py 98.06% <100.00%> (-0.06%) ⬇️
synapse/lib/stormtypes.py 97.99% <100.00%> (+<0.01%) ⬆️
synapse/tests/utils.py 93.68% <0.00%> (-2.16%) ⬇️
synapse/lib/hiveauth.py 96.06% <0.00%> (-0.75%) ⬇️
synapse/lib/view.py 94.18% <0.00%> (-0.70%) ⬇️
synapse/cortex.py 95.91% <0.00%> (-0.68%) ⬇️
synapse/lib/trigger.py 93.91% <0.00%> (-0.44%) ⬇️
synapse/lib/hive.py 98.07% <0.00%> (-0.25%) ⬇️
synapse/lib/lmdbslab.py 99.41% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4b2959...b4dc6f5. Read the comment docs.

@Cisphyx Cisphyx merged commit 02daf6f into master Feb 4, 2021
@Cisphyx Cisphyx deleted the getunivpropcount branch February 4, 2021 19:00
@vEpiphyte vEpiphyte added the bug label Feb 5, 2021
@vEpiphyte vEpiphyte added this to the v2.26.0 milestone Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants