Fix bug that prevented subcluster names with hyphens #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypaulin
approved these changes
Feb 4, 2022
roypaulin
reviewed
Feb 4, 2022
|
Thanks for the heads up about the conflicts. It was the copyright year that I changed, so it was an easy resolution. |
I added the changie in the big copyright year PR I had. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug fix for when the subcluster name in the CR includes hyphens. There are a couple of cases where we need to update the default subcluster in Vertica. The SQL we generated for these commands didn't have quotes around the name, so they were failing. Failure to change the default cluster prevented removal subcluster in some cases and messed up the assignment of nodes to subclusters when creating the database.
Updated the multi-sc testcase (now renamed to multi-sc-sanity) to expose the issue that the bug fix resolves.