Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug to support Endpoints with trailing slashes #161

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

narphu
Copy link
Collaborator

@narphu narphu commented Feb 24, 2022

Any endpoints ending with "/" will not affect DB creation. Not sure if we need a changie entry for this.

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@spilchen spilchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can you add a changie entry for this? Something along the lines of 'Fixed: tolerate slashes being at the end of the communal endpoint url'.

@narphu
Copy link
Collaborator Author

narphu commented Feb 24, 2022

Sure, will add it. I think for first time you may have to approve the workflows.

@narphu
Copy link
Collaborator Author

narphu commented Feb 24, 2022

Looks like the lint fails because of the long test line. I have fixed that in my next commit.

@spilchen spilchen merged commit f19d57c into vertica:main Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants