-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow spread encryption to be set in the VerticaDB CR #224
Conversation
Hi @spilchen , |
@nyikesda the stop DB doesn't wait for active connection. If there are any, those connections will be terminated. This happens immediately after create db though. Do you expect to have a lot of connections come in between? You can use various status conditions to know when the database is fully setup.
|
I do not see --force argument in your code after the admintools -t stop_db, so I thought that it waites for the the active connections. If it the --force argument is not neccessary, then sorry for my previous comment. |
Okay, I understand what you mean. You are right I am missing a force. I'll add that in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I don't have too much to add.
The following parm was added to the VerticaDB CR:
When this is set to vertica, then the
EncryptSpreadComm
parameter will be set for the database right after it is created. Setting encryption in spread requires a server restart, which the operator handles automatically. The default value for this parameter is an empty string, which means no encryption is set.The events for the VerticaDB will look like the following when enabling spread encryption. We will show a successful create database, then a complete server restart.
This can only be set for new instances of VerticaDB. It is ignored if the initPolicy is something other than Create. It only accepts an empty string (to clear encryption) or vertica. The webhook enforces these rules.
The restart was generalized with a new condition variable: VerticaRestartNeeded. In the future, if we have other cases where Vertica needs to be restarted we can use this condition variable.
Closes #222