Allow posix path for communal storage #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes some checks in the webhook so that we can use a POSIX path for communal storage. This should be used only for development purposes. A supported communal path (e.g. S3, HDFS, etc.) should still be used if deploying a production environment. This is to aid in development as it will allow for faster deployments as we don’t need a communal storage service running such as minio. Instead, if you are running on a single host you can use a host path to share communal storage across pods.
Also, I am adding a back door to allow the operator to create and manage an enterprise database. You can get into this mode if you set the shard count in the CR to zero. There is a webhook rule that prevents this, so you will need to disable the webhook to run it this way. This is being added for internal dev testing and is by no way an officially supported use of the operator.