-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New EventTrigger CRD to create Jobs for status changes in the VerticaDB #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spilchen
reviewed
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some early comments. I'll take another pass tomorrow.
spilchen
reviewed
Apr 18, 2023
This updates the following e2e tests to include tests for EventTrigger: - http-custom-certs - http-generated-certs - auto-restart-vertica - non-cluster-admin-deployment - revivedb-1-node
spilchen
reviewed
Apr 19, 2023
We want to share this functionality among other ET reconcilers.
spilchen
reviewed
Apr 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking in good shape. Just a few more comments. But, I think we are really close here.
spilchen
reviewed
Apr 21, 2023
This is needed to maintain the CHANGELOG when we create a new GitHub release.
spilchen
changed the title
Event Trigger
New EventTrigger CRD to create Jobs for status changes in the VerticaDB
Apr 24, 2023
spilchen
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the ability to run arbitrary scripts immediately following a new database creation. This is intended to be used for cases where specific DB initialization is required before the database can be used by apps. We are going to take advantage of the Job type and have the operator create the job when the DB is initialized. This will be handled in a separate custom resource, called the EventTrigger.
The new CRD will allow you to specify what object and states to watch. And it will have a job template in it that will get constructed when the event matches the desired condition. The first use case will look at specific conditions in the VerticaDB. But it is generic enough so that we could extend it for other events in the future -- a future use case that we may want is to watch a secret and update Vertica when its contents change.
This runs as a separate controller in our existing operator pod.
A sample EventTrigger CR is as follows. This will create a user table (T1) right after the VerticaDB completes its database creation.