Reuse node names when installing new k8s pods #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypaulin
reviewed
May 12, 2023
pkg/atconf/file_writer.go
Outdated
| // determines this by finding a free spot in the nodes slice. | ||
| func (f *FileWriter) getNextNodeNumber(nodes []bool) (nextNodeNumber int, newNodes []bool) { | ||
| for i := 0; i < len(nodes); i++ { | ||
| if !nodes[i] { |
There was a problem hiding this comment.
I don't understand what's going on here. Same for buildNodeSlice(). I get what you are trying to do, but not the implementation.
There was a problem hiding this comment.
We are picking the next available node number based on nodes[]. We update this slice as we go, which may involve extending it, so we always return a new copy of nodes[].
Any suggestions on how I can make it easier to understand?
There was a problem hiding this comment.
I think some "why" comments in buildNodeSlice() and getNextNodeNumber() would help. Especially where you extend the slice. And maybe adding, in buildNodeSlice() description, what we are going to do with the slice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects node name reuse when the operator installs new hosts in the admintools.conf. The old reuse logic was a bit too simple and could end up skip reusing a name under certain circumstances.
Note, there are two kinds of node names in vertica. The node name before a node is added to the cluster -- in the format of node####. And the vnode name, which is the name after its added to the cluster -- in the format of v__node####. This impacts only the first format.