Fix timing that causes db add node before install #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 26, 2023 16:28
There is a small timing window with the operator where we would attempt to do an add node before a pod has run install. This isn't a huge problem as the add node would fail and do things in the correct order in the subsequent reconcile iteration. But fixing this will cut down on the amount of noise in the operator log. The fix is to check for the install state when we run add node. If we find a pod with a missing db and it doesn't have an install, we will requeue rather than attempting the add node.
roypaulin
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a small timing window with the operator where we would attempt to do an add node before a pod has run install. This isn't a huge problem as the add node would fail and do things in the correct order in the subsequent reconcile iteration. But fixing this will cut down on the amount of noise in the operator log.
The fix is to check for the install state when we run add node. If we find a pod with a missing db and it doesn't have an install, we will requeue rather than attempting the add node.