SSH secret mounting improvements #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using your own ssh keys through a ssh secret, we now mount the secret for the root user too. This comes in handy if you are running a hybrid k8s server and need to run update_vertica from within the pod. Prior to this change you couldn't do that because the ssh key for the root user was unrecognized. This also mounts the ssh key without using sub path. This allows you to update the ssh secret and see the change in the pod without having to restart the pod. Signed-off-by: Matt Spilchen <[email protected]>
roypaulin
reviewed
Jun 9, 2023
roypaulin
reviewed
Jun 9, 2023
pkg/paths/paths.go
Outdated
| HTTPServerCACrtName = "ca.crt" | ||
| ) | ||
|
|
||
| // MountPaths lists all of the paths for internally generated mounts. | ||
| var MountPaths = []string{LocalDataPath, CELicensePath, MountedLicensePath, | ||
| HadoopConfPath, ConfigPath, ConfigSharePath, ConfigLogrotatePath, | ||
| LogPath, PodInfoPath, AdminToolsConf, AuthParmsFile, EulaAcceptanceFile, | ||
| EulaAcceptanceScript, CertsRoot, Krb5Conf, Krb5Keytab, SSHPath} | ||
| EulaAcceptanceScript, CertsRoot, Krb5Conf, Krb5Keytab, DBAdminSSHPath} |
There was a problem hiding this comment.
Shouldn't you also add RootSSHPath?
roypaulin
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using your own ssh keys through a ssh secret, we now mount the secret for the root user too. This comes in handy if you are running a hybrid k8s server and need to run update_vertica from within the pod. Prior to this change you couldn't do that because the ssh key for the root user was unrecognized.