Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new parameter to the .spec.communal section to allow a CA certificate to be specified. This will allow access to any https s3 endpoint, previously for https we only supported AWS.
The new parameter is called .spec.communal.caFile. It references a file that must exist in the container. You can mount the cert using the .spec.certSecrets.
Here is an example:
In order to test this out, the e2e test was converted to run with minio with an https endpoint. An early commit had introduced two endpoints for testing, and changed the tests to use one of the endpoints. Much of that was undone as this went back to having a single endpoint for the entire test.
In order to get minio https working in the e2e tests, the versions of cert-manager and minio were updated.
Closes #45