Allow NMA certs to be read from GSM #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2023 09:57
roypaulin
reviewed
Dec 4, 2023
| } | ||
| tlsCerts := &corev1.Secret{} | ||
| err := v.Client.Get(ctx, nm, tlsCerts) | ||
| tlsCerts, err := fetcher.Fetch(ctx, names.GenNamespacedName(v.VDB, v.VDB.Spec.NMATLSSecret)) |
There was a problem hiding this comment.
Should we refactor this into a generic function that gets a secret and retrieve https certs?
There was a problem hiding this comment.
Where would you think we would use this generic function?
There was a problem hiding this comment.
I meant to rename retrieveHTTPSCerts to retrieveNMACerts and have a function called retrieveHTTPSCerts that gets the secret name. But we don't need it for now as nma certs are the only one we retrieve.
There was a problem hiding this comment.
I can rename to retriveNMACerts though. That's probably a better name.
added 2 commits
December 4, 2023 15:26
roypaulin
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key change here is to allow the NMA certs to be read in from Google Secret Manager (GSM). This is triggered based on a secret path reference given for the
spec.nmaTLSSecretsecret. The secret path reference for GSM isgsm://. So, the secret name has to be filled in likegsm://projects/1680942424/secrets/mspilchen/versions/6.Some other changes that were made:
MultiSourceSecretFetcherin thecloudpackage.