VCluster API refresh: allow create db to proceed if db is already running #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2024 10:44
spilchen
changed the title
spilchen
commented
Jan 4, 2024
| Nodes: s.RestartHosts, | ||
| } | ||
| // timeout option | ||
| opts := vops.VStartNodesOptionsFactory() |
There was a problem hiding this comment.
Restructured code here so that we call the factor function for opts. This was needed to properly initialize a new field added to the opts.
roypaulin
reviewed
Jan 4, 2024
| // was finished. By ignoring the error this time, we will be able to | ||
| // update the status condition and start any nodes that may be down in | ||
| // order to bring the cluster online. | ||
| dbIsRunningError := &vops.DBIsRunningError{} |
There was a problem hiding this comment.
What do you mean by partially complete? Do you mean on the operator side?
There was a problem hiding this comment.
No, this is the server side. The cases we saw is that create db fails during the package installation. If we got far enough to bring up a vertica process, chances are the database is fine to use.
| @@ -238,6 +248,12 @@ func GetTerminationGracePeriodSeconds(annotations map[string]string) int { | |||
| return lookupIntAnnotation(annotations, TerminationGracePeriodSecondsAnnotaton) | |||
| } | |||
|
|
|||
| // FailCreateDBIfVerticaIsRunning returns how to handle failures during create | |||
| // db if vertica is found to be running. | |||
| func FailCreateDBIfVerticaIsRunning(annotations map[string]string) bool { | |||
There was a problem hiding this comment.
Can you tell what returning true means?
roypaulin
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on a change made in vclusterops. It can now emit a specific error if it discovers that the database is already running. We add a feature flag to tolerate this (the default is true). This can allow us to proceed if we are in an environment with few resources available, which can cause instability during the creation process. If we have previously progressed far enough that Vertica is running, we will skip the create db step and proceed to the next reconciler. This will update the status condition to indicate that the database has been initialized.