Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter supported in more fields like ones in INSERT #3990

Open
wey-gu opened this issue Mar 8, 2022 · 4 comments
Open

Parameter supported in more fields like ones in INSERT #3990

wey-gu opened this issue Mar 8, 2022 · 4 comments
Labels
help wanted Community: does anyone want to work on it? type/enhancement Type: make the code neat or more efficient

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Mar 8, 2022

A user from slack (and also from my side) would consider it's nice to support so ;).

(root@nebula) [basketballplayer]> :param t => "player1000"

(root@nebula) [basketballplayer]> insert vertex player(name,age) values $t:("foo bar", 20);
[ERROR (-1004)]: SyntaxError: Parameter is not supported in vid near `$t'
@wey-gu wey-gu added the type/enhancement Type: make the code neat or more efficient label Mar 8, 2022
@wey-gu wey-gu changed the title Parameter supported in more fields like INSERT Parameter supported in more fields like ones in INSERT Mar 8, 2022
@Shylock-Hg
Copy link
Contributor

Shylock-Hg commented Mar 10, 2022

I think it's caused by incorrect implementation of parameter, we'd better to bind parameter to value when parser generate AST.

@wey-gu
Copy link
Contributor Author

wey-gu commented Oct 22, 2022

cc @MuYiYong
DML Param support

@wey-gu wey-gu added the help wanted Community: does anyone want to work on it? label Oct 22, 2022
@wdroste
Copy link

wdroste commented Nov 1, 2022

Nebula team it would be really good to see this work since its been open since March of this year. I'm sure it will increase the performance of the graphd instance it will certainly make it easier to use from a client perspective.

One more point on the topic:

  • Escaping strings to INSERT is very error prone, so passing strings in by parameters removes that frustration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Community: does anyone want to work on it? type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

3 participants