Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetNeighbors Filter Pushdown for more cases(filter on dst vertex, yield vertex) #4712

Open
wey-gu opened this issue Oct 11, 2022 · 0 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Oct 11, 2022

Introduction
When looking into this discussion in the forum, it's found now the GetNeighbors Pushdown:

  • Only take cares of source vertex conditions filter
  • Don't pushdown when yield dst vertex

we could see ref in tck cases, some DST filter vertex cases were skipped

The mitigation provided are:

  • suggested duplicating some information from DST vertex to edge
  • yield DST(edge) and do FETCH PROP in the pipeline

,which seems doable for now, but it's hard for users to know this trick :-P.

It'll be much easier for users to write performant queries when outgoing edges are like 10K+ if we could try implementing filter pushdown on more cases :).

Contents

Related work

n/a

@wey-gu wey-gu added the type/enhancement Type: make the code neat or more efficient label Oct 11, 2022
@wey-gu wey-gu changed the title GetNeighbors Filter Pushdown GetNeighbors Filter Pushdown for more cases(dst vertex, yield vertex) Oct 11, 2022
@wey-gu wey-gu changed the title GetNeighbors Filter Pushdown for more cases(dst vertex, yield vertex) GetNeighbors Filter Pushdown for more cases(filter on dst vertex, yield vertex) Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

1 participant