Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nebula.Net client library is very old #5564

Closed
porscheme opened this issue May 29, 2023 · 3 comments
Closed

Nebula.Net client library is very old #5564

porscheme opened this issue May 29, 2023 · 3 comments
Labels
affects/none PR/issue: this bug affects none version. severity/none Severity of bug type/question Type: question about the product

Comments

@porscheme
Copy link

porscheme commented May 29, 2023

Please check the FAQ documentation before raising an issue

Describe the bug (required)
Nebual.Net client library is very old

Since its mostly contains auto generated code, please document how to generate the library

@wey-gu please help us.

@porscheme porscheme added the type/bug Type: something is unexpected label May 29, 2023
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels May 29, 2023
@porscheme porscheme changed the title Nebual.Net client library is very old Nebula.Net client library is very old May 29, 2023
@wey-gu
Copy link
Contributor

wey-gu commented May 30, 2023

Dear @porscheme

We could talk about this on https://github.com/nebula-contrib/nebula-net about this topic? The 3.x interface did't change as I recall, thus the client of .net should work, did you encounter any issues?

To generate code for the thrift code of RPC, we could refer to https://github.com/vesoft-inc/nebula-python/blob/master/docs/how-to-update-interface.md .

Thanks!

@wey-gu wey-gu added type/question Type: question about the product and removed type/bug Type: something is unexpected labels May 30, 2023
@porscheme
Copy link
Author

  • We have a need to steam graph query results back the dotnet/csharp client over gRpc
  • Therefor, we wanted to expose a gRpc endpoint which internally uses Nebula.Net
  • We did a PoC, it works fine
  • Just want to make if something has change since Nebula.Net was checked-in

@wey-gu
Copy link
Contributor

wey-gu commented May 30, 2023

Aha, got it. The current dotNet client doesn't require re-generation of thrift as in our versioning policy, there are no break/RPC interface changes in 3.x. It's not been updated for some time but still valid/in good shape.

We have a need to steam graph query results back the dotnet/csharp client over gRpc

That's an interesting arch, maybe in the future, you could share with the community how the graph infra was designed and run in your system :D

Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/none PR/issue: this bug affects none version. severity/none Severity of bug type/question Type: question about the product
Projects
None yet
Development

No branches or pull requests

3 participants