Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--force_phasing True on toil-vg construct doesn't work #777

Open
adamnovak opened this issue Dec 2, 2019 · 2 comments
Open

--force_phasing True on toil-vg construct doesn't work #777

adamnovak opened this issue Dec 2, 2019 · 2 comments

Comments

@adamnovak
Copy link
Member

I ran toil-vg construct with --force_phasing True and vg 1.20.0 when building a GBWT from a VCF set that has phase breaks (1000 Genomes on GRCh37).

The resulting GBWT did not have all contig-length haplotypes in it; there were still phase breaks.

We need to add a test for this option at a small scale, and then work out why it doesn't work (at least with construct) and fix it.

@adamnovak adamnovak changed the title --foirce_phasing True on toil-vg construct doesn't work --force_phasing True on toil-vg construct doesn't work Dec 2, 2019
@adamnovak
Copy link
Member Author

Jouni says the real problem may be that we don't have a way to pass --discard-overlaps, which also causes phase breaks.

@adamnovak
Copy link
Member Author

We also need a way to cover contigs with no VCFs with at least one GBWT thread for the primary path. I'm not sure if we do that already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant