Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anything but config should be inlined #20

Open
dakira opened this issue Apr 24, 2017 · 2 comments
Open

Anything but config should be inlined #20

dakira opened this issue Apr 24, 2017 · 2 comments

Comments

@dakira
Copy link

dakira commented Apr 24, 2017

For a dev-only package it's not desireable to have files added to the actual project. There's already a fix for the fontawesome dependency. What's the problem with the rest, why the need for vendor:publish?

@krve
Copy link
Contributor

krve commented May 2, 2017

The package needs a config to determine when to be active and when not to. Because of this you need to vendor:publish to publish the config.

The public/sudo-su folder could probably be moved inline to prevent adding more files than necessary to the project.

@dakira dakira changed the title Should work without vendor:publish Anything but config should be inlined May 3, 2017
@dakira
Copy link
Author

dakira commented May 4, 2017

I changed the title to express what I think should be done. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants