Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external annotations #60

Open
6 tasks
berombau opened this issue Dec 9, 2020 · 0 comments
Open
6 tasks

Support external annotations #60

berombau opened this issue Dec 9, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@berombau
Copy link
Collaborator

berombau commented Dec 9, 2020

Users should be able to add their own annotations, in the same format as the dataset, by using the Create annotation frontend and a folder. Basic support should include pngseq. The required code changes are:

backend

  • schemas/annotation.py:AnnoationFileType: add pngseq = "pngseq"
  • backend/app/app/api/api_v1/endpoints/utils.py:train_unet2d pass annotation filetype to celery task with new param annotation_filetype

frontend

  • regenerate the code from the backend API as shown in the documentation. This should add the correct file types in the annotation form.

gpu_worker/app/worker.py:train_unet2d

  • add new param annotation_filetype
  • app/worker.py:train_unet2d Skip step Convert JSON annotations to .pngs if filetype is not json.

dash_frontend

  • disable the edit annotation button if the type is not json.

Possible issues:

  • The string representing location of the annotation will change from only a file annotations.json to either a file or a folder. This can break unknown stuff that depended on this assumption e.g. the annotation tools from the dash_frontend viewer or the folder creation in the gpu_worker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants