cmpxchg16b instruction needs 16byte aligned data. #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with DMD 2.067.1, the new atomicLoad() and atomicStore() functions are used. At the core they use cmpxchg16b instruction which needs proper aligned data. The shared HTTPServerContext[] is not properly aligned and causes a segmentation fault with the upcoming LDC 0.16.0. This PR adds align(16) to align the variable.
redstar
added a commit
to redstar/ldc
that referenced
this pull request
Sep 10, 2015
This is required for compiling latest vibe.d version. Please note that a fix to vibe.d is also required, see vibe-d/vibe.d#1255
redstar
added a commit
to redstar/ldc
that referenced
this pull request
Sep 10, 2015
This is required for compiling latest vibe.d version. Please note that a fix to vibe.d is also required, see vibe-d/vibe.d#1255
redstar
added a commit
to redstar/ldc
that referenced
this pull request
Sep 10, 2015
This is required for compiling latest vibe.d version. Please note that a fix to vibe.d is also required, see vibe-d/vibe.d#1255
s-ludwig
added a commit
that referenced
this pull request
Sep 11, 2015
cmpxchg16b instruction needs 16byte aligned data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with DMD 2.067.1, the new atomicLoad() and atomicStore() functions are used.
At the core they use cmpxchg16b instruction which needs proper aligned data.
The shared HTTPServerContext[] is not properly aligned and causes a segmentation fault
with the upcoming LDC 0.16.0.
This PR adds align(16) to align the variable.