Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for i18n language arrays #1879

Merged
merged 2 commits into from
Nov 5, 2017

Conversation

WebFreak001
Copy link
Contributor

Redo of #1869 because that one was on master and I accidentally updated that branch

@s-ludwig
Copy link
Member

I was wondering if this couldn't be shortened to something like:

template languageSeq(CTX) {
    static if (is(typeof([CTX.languages]) : string[])) alias languageSeq = CTX.languages;
    else alias languageSeq= aliasSeqOf!(CTX.languages);
}

and then use languageSeq!CTX instead of CTX.languages.

The change itself definitely makes a lot of sense.

@WebFreak001
Copy link
Contributor Author

Hm yeah, made it use your code there now and validated by compiling the i18n example

@s-ludwig
Copy link
Member

s-ludwig commented Nov 5, 2017

Thanks. Failures just look like previous errors that managed to get on master.

@s-ludwig s-ludwig merged commit cd46fb4 into vibe-d:master Nov 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants