Fix bogus mailto links generated by the Markdown parser. #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
reviewed
May 17, 2018
| url = pstr[0 .. cidx]; | ||
| if( anyOf(url, " \t") ) return false; | ||
| if( !anyOf(url, ":@") ) return false; |
There was a problem hiding this comment.
I don't think anything changes related to this condition, because it is replicated below as atidx < 0 && colonidx < 0. ":@" will not be accepted due to the length check at the top, but indeed this will let a lot of invalid cases go through. True validation has to be done as a separate step
| test(false, "<http://foo/", null); | ||
| test(true, "<mailto:foo@bar>", "mailto:foo@bar"); | ||
| test(true, "<foo@bar>", "mailto:foo@bar"); | ||
| test(true, "<proto:foo@bar>", "proto:foo@bar"); |
There was a problem hiding this comment.
Maybe a test that checks for : after @?
e.g. when a custom port is used
There was a problem hiding this comment.
Added, plus allowed "foo:foo"@bar style e-mail addresses.
Whenever an "at" character was in an auto URL, the contents were treated as an e-mail address. This was even the case for URLs such as "http://foo/bar@baz".
s-ludwig
force-pushed
the
fix_markdown_email_links
branch
from
2681ceb
to
a844b9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever an "at" character was in an auto URL, the contents were treated as an e-mail address. This was even the case for URLs such as "http://foo/bar@baz".