Fix destructor behavior of BufferedStream #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since BufferedStream has RAII semantics, the destructor performs an implicit flush to and of the underlying stream, which can in turn throw an exception. In order to still let the destruction happen semantically, any such exception is now rethrown after performing a full clean-up. This means that the data that has not been flushed will be lost, but the state of the object will be so that another destroy() call will be a no-op and no resources are referenced anymore.
l-kramer
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since BufferedStream has RAII semantics, the destructor performs an implicit flush to and of the underlying stream, which can in turn throw an exception. In order to still let the destruction happen semantically, any such exception is now rethrown after performing a full clean-up. This means that the data that has not been flushed will be lost, but the state of the object will be so that another destroy() call will be a no-op and no resources are referenced anymore.