New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent resolveHost() param #430

Closed

pszturmaj opened this issue Dec 7, 2013 · 0 comments

pszturmaj commented Dec 7, 2013

In vibe.core.net there's resolveHost() with use_dns param which is passed as is to driver's resolveHost() taking no_dns param.

Quick fix would be:

NetworkAddress resolveHost(string host, ushort address_family = AF_UNSPEC, bool use_dns = true)
{
    return getEventDriver().resolveHost(host, address_family, !use_dns);
}

but I guess you may want to change the driver's function signature instead, or fix it in different way.

s-ludwig closed this as completed in

d49f615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment