Fix issue #505: DIET: doctype is actually ignored

[nazriel]

Fix issue #505

Again, not sure if it is the best approach.

Btw, I didn't know if I should use:

case "!!!":
    ln = ln[j + 3 .. $]; 
    goto case "doctype";
case "doctype"
...

Or the one I used in code.

Also I am not sure if code guidelines are correct.
Btw what is maximum column line, 120?

Edit: Should I add unittest with those cases?

[nazriel]

Travis failure seems to be unrelated.
Unittests passed on my computer.

Btw, if it gets merged I will try to fix issue #475

[s-ludwig]

Btw, I didn't know if I should use:

case "!!!":
    ln = ln[j + 3 .. $]; 
    goto case "doctype";
case "doctype"
...

Or the one I used in code.

I'd even go a line up and change

if( ln.startsWith("!!! ") ) tag = "!!!";

to

if (ln.startsWith("!!! ")) {
    // later: output.writeCode(`pragma(msg, "\"!!!\" is deprecated, use \"doctype\" instead.");`)
    tag = "doctype";
    j += 4;
}

Code style wise it looks good, except for maybe the indented ~ "... parts, which I would only indent with a single tab, but that's really not critical. Even though there is no strict line Iength limit (120 is kind of a soft limit and 80 for doc comments), I would move the "doctype" case contents to a separate buildDoctypeNodeWriter function in this case, because the nesting gets a little deep.

BTW: I've found the rationale for the deprecation of !!!: pugjs/pug#1270
I'm not sure if I can really agree with that, but it will be good to stay compatible if thats the definite way they go.

[nazriel]

@s-ludwig updated!
I left it to you to decide when we deprecate !!!

[s-ludwig]

Perfect, thanks!

[nazriel]

Thank you!