Fix RedisClient instantiation for authentication
#785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the "INFO" command from the default `RedisClient` constructor, since its only there to support the `redisVersion` getter. This fixes creating clients for databases that require authentication for all commands. It moves the version fetching logic into the `redisVersion` getter, and caches its result in the `m_version` property. I think this is the cleanest solution to this issue.
yamadapc
added a commit
to yamadapc/dmin.io
that referenced
this pull request
Aug 19, 2014
This currently depends on vibe-d/vibe.d#785 and is required for us to deploy this to Heroku.
|
Can I get some feedback on this? It makes deploying vibe.d applications which use redis to heroku impossible. Maybe I missed something, but this is a pretty big bug. |
|
I removed a line I shouldn't have, if you want I'll push force and update the commit to be prettier. The ugly diff (because of moving code from a function to another) can't really be avoided. I'm sorry about it too. |
|
It basically makes |
|
Looks good indeed. Merging. (Sorry, I completely missed this pull request before) |
s-ludwig
added a commit
that referenced
this pull request
Aug 21, 2014
Fix `RedisClient` instantiation for authentication
|
Awesome! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the "INFO" command from the default
RedisClientconstructor, since its only there to support the
redisVersiongetter.This fixes creating clients for databases that require authentication
for all commands. It moves the version fetching logic into the
redisVersiongetter, and caches its result in them_versionproperty. I think this is the cleanest solution to this issue.