Skip to content

Commit

Permalink
fix(tech): add abstract crossOrigin method on Tech (#6765)
Browse files Browse the repository at this point in the history
As part of #6588, we started using the crossOrigin method. However, it's
possible that a tech doesn't support this. Notably, the Flash tech. We
should instead have an abstract method on Tech that returns nothing so
we don't fail on those browsers.
  • Loading branch information
gkatsev authored Jul 20, 2020
1 parent d4430a3 commit 245efac
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions src/js/tech/tech.js
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,25 @@ class Tech extends Component {
*/
reset() {}

/**
* Get the value of `crossOrigin` from the tech.
*
* @abstract
*
* @see {Html5#crossOrigin}
*/
crossOrigin() {}

/**
* Set the value of `crossOrigin` on the tech.
*
* @abstract
*
* @param {string} crossOrigin the crossOrigin value
* @see {Html5#setCrossOrigin}
*/
setCrossOrigin() {}

/**
* Get or set an error on the Tech.
*
Expand Down

0 comments on commit 245efac

Please sign in to comment.