Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lang): added arabic seek button translations #8616

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

silevitas
Copy link
Contributor

Description

Added two Arabic new seek button translations.

Specific Changes proposed

Arabic translations for Skip backward {1} seconds and Skip forward {1} seconds.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.71%. Comparing base (a57b07a) to head (4ce9836).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8616   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files         113      113           
  Lines        7636     7636           
  Branches     1835     1835           
=======================================
  Hits         6316     6316           
  Misses       1320     1320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben
Copy link
Contributor

This line and the corresponding one in the forward buttons should use this.skipTime.toLocaleString(player.language()) so actual Arabic numbers rather than what we call Arabic numbers are used.

this.controlText(this.localize('Skip backward {1} seconds', [this.skipTime]));

@silevitas
Copy link
Contributor Author

Added the localisation support to the skipButtons as recommended!

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label Mar 4, 2024
@mister-ben mister-ben merged commit ee07382 into videojs:main Apr 12, 2024
10 checks passed
Copy link

welcome bot commented Apr 12, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants