-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update karma dependencies #8743
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mister-ben
changed the title
chore: Update karma dependenciess
chore: Update karma dependencies
May 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8743 +/- ##
==========================================
+ Coverage 83.15% 83.76% +0.61%
==========================================
Files 120 120
Lines 7995 7995
Branches 1924 1924
==========================================
+ Hits 6648 6697 +49
+ Misses 1347 1298 -49 ☔ View full report in Codecov by Sentry. |
adrums86
approved these changes
May 30, 2024
9 tasks
This was referenced Aug 1, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates karma dependencies. This includes an update to karma-firebox-launcher via videojs-generate-karma-config, however tests won't run on Firefox without manual intervention as karma-detect-browsers would also need to be updated (with the correct fief executable name) and that doesn't seem likely.
Requirements Checklist