fix(types): Add has|usingPlugin to typedef by adding stubs which are removed from builds #8811
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tsc doesn't understand mixins and ignores jsdoc not followed by code. The jsdoc for the plugin methods
usingPlugin()
andhasPlugin()
in Player are being ignored. To get them included in type outputs we need to have otherwise unnecessary stubs codes, as we already have foron()
etc, which adds unnecessary, even if a small amount of, code to the outputs.Specific Changes proposed
on()
etc stubs in Component and the new plugin stubs in Player.Any code surrounded by these comments, and the comments themselves, is deleted from the dist and test builds:
Compared to main, video.min.js is 53 bytes smaller.
Requirements Checklist
npm run docs:api
to error