Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some checks for Escape key use incorrect value #8915

Closed
gkatsev opened this issue Nov 13, 2024 · 0 comments · Fixed by #8916
Closed

some checks for Escape key use incorrect value #8915

gkatsev opened this issue Nov 13, 2024 · 0 comments · Fixed by #8916

Comments

@gkatsev
Copy link
Member

gkatsev commented Nov 13, 2024

looks like during review, we missed that these should be Escape rather than Esc, which keycode, the library we used previously, likely helped with. Someone noticed this issue in slack.

Originally posted by @gkatsev in #8735 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix Escape handling in menus mister-ben/video.js
1 participant
@gkatsev