-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fatal error when using threads #1601
Comments
Do things still break if you run with |
Yeah, the output is exactly the same when run with |
Mind running with |
I am experiencing the same issue, and am in the same boat with the closed source codebase :-/ Here is what i get from the last few lines of output with
Interestingly, the last letter is missing from the path to my codebase in number 4 |
The last one was for version 3.2.2. With version 3.2.10 and using
and for completeness $ ./vendor/bin/phpunit --version
PHPUnit 7.5.7 by Sebastian Bergmann and contributors. |
Signal 11 is SIGSEGV, so Psalm managed to crash PHP somehow. |
I've just added some extra debugging for the scanning step to latest master. What platform are you running on? |
Mac OS with PHP version 7.2.17 from Nix. I don't see any core dumps in my home directory or my project folder. I'll poke around later and see if I can get a proper core dump. |
What do you see when you use latest master with debug flag turned on? |
Also what extensions are enabled? |
I'm on macOs 10.14.4 with PHP 7.3.5 installed via Homebrew.
I've tried with the latest Psalm master branch and still see the issue. I've included a dump of a run with
|
@muglug psalm/src/Psalm/Internal/Fork/Pool.php Lines 225 to 249 in d7ee952
|
@jaikdean I'm sorry this is happening - would you be able to add some var_dumps in @andrew-demb are you getting a crash too? Or are you just looking at the code? |
I don't have the bandwidth fiddle with master today. I will turn multithreading on in circle-ci and see if I can reproduce in Linux while i'm working today. If so I'll give you the name of the docker image we are using. Here are my modules. It's a very slightly shorter list:
|
I met similar errors (not sure about core dumps) about two months ago and just not using threads. |
After much digging, I've tracked this down to an issue with PHP 7.3's PCRE2 and appears to be related to this issue with Homebrew's installation of PHP, with some more detail here. Setting |
Thanks! Psalm now prevents threaded execution if |
Had the same issue on Linux with php 7.4 |
Please create a new issue with your exact error message |
When we run Psalm in one thread it works as expected:
However, when running in more than one, we see fatal errors:
This is a private, commercial project, so I'm unable to share the code to aid in debugging, but if there's anything else I can run to get more useful information, please let me know.
Thanks for making Psalm, it's a fantastic tool and has helped improved our code quality massively.
The text was updated successfully, but these errors were encountered: