Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for new conrad version #36

Closed
vinayak-mehta opened this issue Oct 29, 2019 · 1 comment · Fixed by #61
Closed

Check for new conrad version #36

vinayak-mehta opened this issue Oct 29, 2019 · 1 comment · Fixed by #61
Labels
enhancement New feature or request

Comments

@vinayak-mehta
Copy link
Owner

Compare user's conrad.__version__ with the latest release on PyPI and suggest them to upgrade conrad periodically.
@vinayak-mehta vinayak-mehta added enhancement New feature or request hacktoberfest labels Oct 29, 2019
@abhi-baireddy
Copy link
Contributor

@vinayak-mehta I worked on this. I added a new function in the main.py file that gets the current version of conference-radar using the PyPI API, checks if it is the latest and prompts the user to upgrade if so. I am not quite sure if I made the changes in the right place. Please help me if I got it wrong or if there's anything I can improve. This is my first ever contribution.

After I made the PR, deepsource showed some errors. I will take care of them if what I did is correct in the first place. I'm still learning!

Thanks!

@abhi-baireddy abhi-baireddy mentioned this issue Nov 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] Add self version check abhi-baireddy/conrad
2 participants
@vinayak-mehta @abhi-baireddy