Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update available evolutions based on the candy received after a transfer #174

Open
YesThatAllen opened this issue Dec 20, 2016 · 7 comments

Comments

@YesThatAllen
Copy link
Contributor

YesThatAllen commented Dec 20, 2016

When counting candies to evolves, keep in mind that we get one back for every evolve.

eg: if I want to evolve 10 Pidgies in a row, I need 12 for the first, then the one I get back after the evolution, meaning I need only 11 for the next.

10x11+1=111 candies.. as opposed to 10x12=120 candies.

Once I have 23 candies (and at least 2 Pidgey), I can make two Pidgeottos.

Currently, PokeNurse not show that I have two evolutions available until I had 24 candies.

This is also directly related to the conversation at #101

@YesThatAllen YesThatAllen changed the title Update available evolutions based on the candy we get afterwards Update available evolutions based on the candy received after a transfer Jan 6, 2017
@hacknug
Copy link
Contributor

hacknug commented Mar 5, 2017

I think I've fixed it. Let me make sure it's right and I can submit a PR for this.

@vinnymac
Copy link
Owner

vinnymac commented Mar 7, 2017

Nice, I think we have a lot more info available then we used to, I am hoping this is just some math we need to do. I'll review the PR if you make one.

@hacknug
Copy link
Contributor

hacknug commented Mar 7, 2017

This was just some math, indeed. Was waiting to hear your thoughts on it before the PR. Will try to submit it later today so you can review and maybe @YesThatAllen can confirm it's working as expected.

@YesThatAllen
Copy link
Contributor Author

YesThatAllen commented Mar 7, 2017

Happy to, looking forward to it.

@hacknug
Copy link
Contributor

hacknug commented Mar 7, 2017

Here you go #202

@YesThatAllen
Copy link
Contributor Author

#202 gets the math right in the preview,

screenshot_4231

36 pidgey need 36*11 = 396 +1 = 397 total. (This is correct.)

However, the Evolves column is still off.

227-1=226/11=20.5= 20 evolves

@hacknug
Copy link
Contributor

hacknug commented Mar 14, 2017

My bad. Didn't thought about changing anything else besided those tooltips. Will check it when I get home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants