Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client dependency problems #926

Closed
sgfost opened this issue Dec 18, 2023 · 1 comment
Closed

client dependency problems #926

sgfost opened this issue Dec 18, 2023 · 1 comment
Labels
blocker client Client Side dependencies Pull requests that update a dependency file

Comments

@sgfost
Copy link
Contributor

sgfost commented Dec 18, 2023

occurring in #925 and whenever packages are upgraded with yarn

seems like two issues:

1. bug in yarn (classic) with resolving eslint dependencies:

Can be fixed by pinning certain versions or upgrading yarn (which comes with more problems)

2. vite 5.0 gets picked up as a dependency for vitest which contains some import that TS doesn't handle correctly

Again, can be fixed by pinning vite in "resolutions". Suggested fix seems to be setting moduleResolution: bundler in tsconfig but this produces tons more issues


'correct' fix is probably upgrading yarn and using "moduleResolution": "bundler" for typescript on the client but each present a whole new set of problems to figure out

npm might be worth a try..

@sgfost sgfost added client Client Side dependencies Pull requests that update a dependency file blocker labels Dec 18, 2023
@sgfost
Copy link
Contributor Author

sgfost commented Dec 18, 2023

npm is much smoother sailing, I'm happy to switch and not look back

I don't currently see a way to make moduleResolution: bundler (or es2016) work with some of our dependencies so we may need to just pin vite to v4 for now

sgfost added a commit to sgfost/port-of-mars that referenced this issue Dec 22, 2023
sgfost added a commit to sgfost/port-of-mars that referenced this issue Dec 22, 2023
sgfost added a commit to sgfost/port-of-mars that referenced this issue Dec 22, 2023
@alee alee closed this as completed in da36603 Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker client Client Side dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant