Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node-lzo or acknowledge GPL2 #2105

Open
kylebarron opened this issue Mar 9, 2022 · 1 comment
Open

Remove node-lzo or acknowledge GPL2 #2105

kylebarron opened this issue Mar 9, 2022 · 1 comment

Comments

@kylebarron
Copy link
Collaborator

kylebarron commented Mar 9, 2022 •
edited
Loading

As I was browsing through the Parquet code recently, I noticed that we depend on lzo where the Node bindings are MIT licensed but the underlying C library is GPL2. See schroffl/node-lzo#12

According to Wes Mckinney, apache/arrow#2209 (comment)

LZO isn't really used anymore (as soon as Snappy came around people largely stopped using it because of the *GPL licensing issues)

Just thought it would be worthwhile to make an issue about this while I was thinking about it.
@ibgreen
Copy link
Collaborator

ibgreen commented Mar 9, 2022

I was trying to add LZO as an optional dependency but I suppose in that case we really should explain the licensing situation to users.

I am very open to removing LZO in 3.2. Supporting LZO on browsers will require a bunch of work anyways, and it is a huge dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ibgreen @kylebarron