Fix URI encoding (#1539)

According to HTTP spec keys should be encoded slightly differently to values.
ladjs · Feb 17, 2020 · c7a10e2 · c7a10e2
1 parent 40424e6
commit c7a10e2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/client.js b/src/client.js
@@ -128,7 +128,7 @@ function serialize(obj) {
 function pushEncodedKeyValuePair(pairs, key, val) {
   if (val === undefined) return;
   if (val === null) {
-    pairs.push(encodeURIComponent(key));
+    pairs.push(encodeURI(key));
     return;
   }
 
@@ -142,7 +142,7 @@ function pushEncodedKeyValuePair(pairs, key, val) {
         pushEncodedKeyValuePair(pairs, `${key}[${subkey}]`, val[subkey]);
     }
   } else {
-    pairs.push(encodeURIComponent(key) + '=' + encodeURIComponent(val));
+    pairs.push(encodeURI(key) + '=' + encodeURIComponent(val));
   }
 }
 

diff --git a/test/client/serialize.js b/test/client/serialize.js
@@ -35,6 +35,7 @@ describe('request.serializeObject()', () => {
     serialize({ name: '&tj&' }, 'name=%26tj%26');
     serialize({ '&name&': 'tj' }, '%26name%26=tj');
     serialize({ hello: '`test`' }, 'hello=%60test%60');
+    serialize({ $hello: 'test' }, '$hello=test');
   });
 });