feat(fit): allow custom zoom level limits #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are optional and default to the same values as before (that is no breaking change), they are limited to values above 0 (zero would lead to infinities, NaNs etc. and I have no idea what negative zoom should mean) and max can't be lower than min. There's visual regression test included.
yotamberk
approved these changes
Oct 25, 2020
|
does this solve #629 too? |
Nope, this applies only to the fit method. |
|
🎉 This PR is included in version 8.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are optional and default to the same values as before (that is no breaking change), they are limited to values above 0 (zero would lead to infinities, NaNs etc. and I have no idea what negative zoom should mean) and max can't be lower than min. There's visual regression test included.
Closes #1114.