Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): ensure correct typing for node esm #179

Merged
merged 2 commits into from
Aug 14, 2023
Merged

fix(build): ensure correct typing for node esm #179

merged 2 commits into from
Aug 14, 2023

Conversation

xiaoxiangmoe
Copy link
Contributor

Description

fix #48 #137

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@xiaoxiangmoe xiaoxiangmoe mentioned this pull request Jul 19, 2023
Merged
9 tasks
@haoqunjiang haoqunjiang merged commit 8a19ee4 into vitejs:main Aug 14, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

moduleResolution: nodenext typing issue
3 participants
@xiaoxiangmoe @antfu @haoqunjiang