Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugin-vue): simplify logic of resolving script #300

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

HydratedPig
Copy link
Contributor

Description

There are simplified functions available for resolving the clientCache or ssrCache, but the code in resolveScript still directly utilizes the cache. This pull request aims to replace the old code with getResolvedScript and setResolvedScript.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sxzz sxzz changed the title chore: update the logic for resolving the cached script in resolveScript refactor(plugin-vue): simplify logic of resolved script Nov 20, 2023
@sxzz sxzz changed the title refactor(plugin-vue): simplify logic of resolved script refactor(plugin-vue): simplify logic of resolving script Nov 20, 2023
@sxzz sxzz merged commit 2ac1045 into vitejs:main Nov 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants