Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent source maps #12885

Closed
7 tasks done
sheremet-va opened this issue Apr 17, 2023 · 3 comments · Fixed by #12902
Closed
7 tasks done

Inconsistent source maps #12885

sheremet-va opened this issue Apr 17, 2023 · 3 comments · Fixed by #12902
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@sheremet-va
Copy link
Member

sheremet-va commented Apr 17, 2023

Describe the bug

When passing down SSR flag to transformRequest, it returns incorrect map sources (should be relative, like when you don't pass ssr flag) if the file has .js extension and didn't have a map before. I wasn't able to reproduce the issue any other way.

Reproduction

https://stackblitz.com/edit/node-tb5tp5?file=folder%2Ftest.js,index.js

Steps to reproduce

Run node index.js

System Info

Stackblitz

Used Package Manager

npm

Logs

No response

Validations

@stackblitz
Copy link

stackblitz bot commented Apr 17, 2023

Fix this issue in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@fi3ework

This comment was marked as off-topic.

@sheremet-va
Copy link
Member Author

sheremet-va commented Apr 17, 2023

Made a manual reproduction of

sources field is not consistent with other source maps. It should always be relative to the source map. Currently, it just puts whatever you pass down to transformRequest.

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) and removed pending triage labels May 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants