Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: the shortcut fails to open browser when set the host #13579

Merged
merged 2 commits into from
Jun 21, 2023
Merged

fix: the shortcut fails to open browser when set the host #13579

merged 2 commits into from
Jun 21, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Jun 21, 2023

Description

fix #13575

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jun 21, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jun 21, 2023
sapphi-red
sapphi-red approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-dev patak-dev merged commit e0a48c5 into vitejs:main Jun 21, 2023
@btea btea deleted the fix/shortcuts-open-browser branch June 21, 2023 12:09
@mempf
Copy link

mempf commented Jun 21, 2023

@btea @patak-dev Thanks for fixing this so quickly!

@btea btea mentioned this pull request Jun 29, 2023
Merged
9 tasks
xinxinhe1810 pushed a commit to xinxinhe1810/vite that referenced this pull request Jul 4, 2023
@btea @xinxinhe1810
fix: the shortcut fails to open browser when set the host (vitejs#13579)
ba595d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't open browser with 'o' shortcut when using --host option
4 participants
@btea @mempf @patak-dev @sapphi-red