-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: "EISDIR: illegal operation on a directory, realpath" error on RA… #13655
fix: "EISDIR: illegal operation on a directory, realpath" error on RA… #13655
Conversation
…M and virtual disks in Windows, which bypass Mounting Manager (like ImDisk).
Run & review this pull request in StackBlitz Codeflow. |
…mapped version when using fs.realpathSync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! cc @userquin in case you have comments about this PR
Facing same issue. Can this be merged, please? |
Are you sure the bug is fixed? (According to release notes in 4.4.5 (2023-07-20)) I can reproduce it vite "4.4.9. $ node "./scripts/commands/preProcessSpec.js" I just map the RAM disk to node_modules and start a build |
@qub1n please avoid commenting on old PRs. If you tested on the latest version of Vite (5.1.4), and you think there is something in core that could be improved, please create a new issue with a minimal reproduction against latest (and more info about your system and setup). |
Fix "EISDIR: illegal operation on a directory, realpath" error on RAM and virtual disks in Windows, which bypass Mounting Manager (like ImDisk).
Description
On virtual and RAM disks in Windows which bypass the Mounting Manager (e.g. ImDisk), the error "EISDIR: illegal operation on a directory, realpath" occurs when calling fs.realpathSync.native.
These functions require the disk volume to be managed by the Mount Manager to find mount points, etc. ImDisk does not interact with Mount Manager at all, so all such operations will end in an error.
The solution to this problem is the try catch code wrapper.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).