fix(cli): convert the sourcemap option to boolean (fix #13638) #13663
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #13638
ee3b90a added
'inline'
and'hidden'
as options to--sourcemap
in the CLI and broke the behavior of booleans, i.e.true
andfalse
became strings. This resulted in--sourcemap false
to still output sourcemaps.Additional context
There's not really a clean way to convert
'true'
and'false'
to a boolean. Feel free to suggest a different approach.Also, I'm not sure if a test case should be added for this. It's my first contribution and didn't see tests related to CLI options.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).