-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use file extensions on type imports so they work with moduleResolution: 'node16'
#13947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duleResolution: 'node16'`
Run & review this pull request in StackBlitz Codeflow. |
Princesseuh
changed the title
Use file extensions on type imports so they work with
fix: Use file extensions on type imports so they work with Jul 25, 2023
moduleResolution: 'node16'
moduleResolution: 'node16'
bluwy
added
the
p3-downstream-blocker
Blocking the downstream ecosystem to work properly (priority)
label
Jul 25, 2023
Princesseuh
changed the title
fix: Use file extensions on type imports so they work with
fix: use file extensions on type imports so they work with Jul 25, 2023
moduleResolution: 'node16'
moduleResolution: 'node16'
bluwy
approved these changes
Jul 25, 2023
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
patak-dev
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same projects are currently failing against main. Let's merge this one. Thanks @Princesseuh!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At Astro we're currently (attempting) to migrate our
tsconfig.json
tomoduleResolution: 'node16'
. We got it mostly figured out, apart from one thing: We can't import types from Vite. Investigating led me to realize that it was because Vite's type imports don't have file extensions, so they always resolve asany
undermoduleResolution: 'node16'
. I tried to workaround this by importing the files in thetypes
folder individually, but they're not part of theexports
map so.This PR adds file extensions to all the imports, easy enough. I tested it downstream and it works. Per #11552, it seems like many users were patching Vite manually for this already.
Additional context
Downstream is currently not able to migrate to
moduleResolution: 'node16'
, so this is kinda blocking.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).