-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: bump minimum node version to 18 #14030
Conversation
Run & review this pull request in StackBlitz Codeflow. |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
Let's wait a bit with this one, asking for feedback about when WebContainers will move to Node 18. I tried codeflow and it works apart from a few warnings so we could also merge it before we release the first alpha/beta. |
If we bump to 18.4.0, we can simplify this part. vite/packages/vite/src/node/utils.ts Lines 924 to 926 in 6cb397f
(Because it will include nodejs/node#43054) That said, I think it's fine going with 18.0.0 as this is a tiny one. |
The version in StackBlitz should be updated after Node 16 EOL, let's move forward with this one. It stills works, there is only a warning. I already removed node-14 and node-16 from the test matrix. |
Description
Bump the packages in this monorepo to require minimum node 18. Not sure if we need to bump to a specific minor version of 18, currently have it at 18.0.0
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).