-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(manifest): preserve pure css chunk assets #14297
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Can you help check this PR in svelte-kit? Thanks @benmccann |
I wonder if it's possible to handle when removing the pure CSS chunk. vite/packages/vite/src/node/plugins/css.ts Lines 768 to 775 in 66a97be
|
Yeah ,that would be more simple 👍 |
Yes, I see SvelteKit generating the preload header tags when linked against this PR. Thank you so much for fixing this!! |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
Looks like the ones that passed in main also passed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
fix #14244
pureCssChunk
will be removed totally with itsimportedAssets
. Thus theseimportedAssets
would be orphaned in themanifest.json
.This PR tries to preserve these
importedAssets
via attaching them withpureCssChunk
's emitted css.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).