Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-vite): remove tsc command from qwik template #15982

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

sapphi-red
Copy link
Member

Description

No other js template runs tsc.
Currently, it just shows the help message and blocks the build running.

npm run build

> [email protected] build
> tsc && vite build

Version 5.3.3
tsc: The TypeScript Compiler - Version 5.3.3
                                                                                                                     TS
COMMON COMMANDS

  tsc
  Compiles the current project (tsconfig.json in the working directory.)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Feb 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove the typescript dev dep?

@bluwy bluwy added p3-minor-bug An edge case that only affects very specific usage (priority) feat: create-vite create-vite package labels Feb 21, 2024
@patak-dev patak-dev enabled auto-merge (squash) February 21, 2024 10:51
@sapphi-red
Copy link
Member Author

Should we also remove the typescript dev dep?

Ah, yeah. @patak-dev Thanks!

@patak-dev patak-dev merged commit 5e05f10 into vitejs:main Feb 21, 2024
10 checks passed
@sapphi-red sapphi-red deleted the fix/qwik-template-tsc branch February 21, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: create-vite create-vite package p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants