Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable some eslint rules #18084

Merged
merged 7 commits into from
Sep 12, 2024
Merged

chore: enable some eslint rules #18084

merged 7 commits into from
Sep 12, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 12, 2024

Description

Enable some rules in the eslint config marked TODO. Some are still disabled for playground code.

I left some as 'off' still as it felt like the better default for us.

Copy link

stackblitz bot commented Sep 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy changed the title chore: enable @typescript-eslint/no-unused-vars chore: enable some eslint rules Sep 12, 2024
sapphi-red
sapphi-red previously approved these changes Sep 12, 2024
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

packages/vite/src/node/plugins/css.ts Outdated Show resolved Hide resolved
Co-authored-by: 翠 / green <[email protected]>
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great to see plain ifs enforced

@patak-dev patak-dev merged commit e9a2746 into main Sep 12, 2024
9 of 12 checks passed
@patak-dev patak-dev deleted the eslint-update branch September 12, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants