Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-vue-jsx): replace default export with helper during SSR #3966

Merged
merged 2 commits into from
Jun 26, 2021
Merged

fix(plugin-vue-jsx): replace default export with helper during SSR #3966

merged 2 commits into from
Jun 26, 2021

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented Jun 25, 2021

fixes #2662

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

patak-dev
patak-dev previously approved these changes Jun 25, 2021
View reviewed changes
@patak-dev patak-dev requested a review from antfu June 25, 2021 20:00
@antfu antfu changed the title fix(jsx): replace default export with helper during SSR fix(plugin-vue-jsx): replace default export with helper during SSR Jun 25, 2021
@antfu antfu merged commit bc86464 into vitejs:main Jun 26, 2021
@KaelWD KaelWD deleted the patch-1 branch June 27, 2021 05:25
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@KaelWD @aleclarson
fix(plugin-vue-jsx): replace default export with helper during SSR (v…
806db66 
…itejs#3966)
@sapphi-red sapphi-red mentioned this pull request Jun 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

@antfu antfu Awaiting requested review from antfu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[plugin:plugin-vue-jsx] Unable to convert tsx correctly when performing server side rendering in SSR mode
3 participants
@KaelWD @patak-dev @antfu